Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ignore errors #224

Merged
merged 2 commits into from
Jul 7, 2014
Merged

Conversation

skovhus
Copy link

@skovhus skovhus commented Jul 7, 2014

No description provided.

@mattrobenolt
Copy link
Contributor

Can you add this to the tests, please? :)

@skovhus
Copy link
Author

skovhus commented Jul 7, 2014

@mattrobenolt sure, something like this?

@mattrobenolt
Copy link
Contributor

Yup! That works. Thanks. 🍰

mattrobenolt added a commit that referenced this pull request Jul 7, 2014
@mattrobenolt mattrobenolt merged commit 9b901a7 into getsentry:master Jul 7, 2014
@skovhus
Copy link
Author

skovhus commented Jul 9, 2014

@mattrobenolt two things:

i realize now that when adding a string to the whitelist filter, you don't start the regexp with a ^ or end it with $, e.g. the string can appear anywhere in the exception message. So:

globalOptions.ignoreErrors.push('Script error.');
globalOptions.ignoreErrors.push('Script error');

Is actually covering ... Javascript error: Script error on line ... error already. But also This is a script error that should be handled...... : /

Is this deliberately? It is rather confusing. Maybe this also confused when writing the two rules as the first rule is covered by the second one.

The thing I don't understand is why these errors still end up in Sentry... Testing locally by throw new Error('Javascript error: Script error on line 0')shows that the current default whitelist in raven-js works, but in production it ends up in Sentry. Any thoughts?

@skovhus
Copy link
Author

skovhus commented Aug 11, 2014

@mattrobenolt Any comments?

@skovhus skovhus mentioned this pull request Nov 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants