next-plugin-sentry: moved dependencies #3453
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I've noticed the issue with dependencies in the
next-plugin-sentrywhich currently has@sentry/nextjsin its dependencies. This leads to the issue in my project:As you can see from the screenshot, It uses the internal version of the
@sentry/nextjspackage instead of the one from the project. I think that it's not correct behavior, it seems to me that this package should not bring@sentry/nextjspackage as dependency. That's why I moved it todevDependenciesandpeerDependencies. This looks like a correct approach, I think. I tested it in my project, the error disappears if I remove that nestednode_modulesfolder. So this PR should help.Please let me know what you think about it. Thanks!