Use window.crypto for uuid4 if present #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }); | ||
| var crypto = window.crypto || window.msCrypto; | ||
|
|
||
| if (typeof(crypto) !== 'undefined' && crypto.getRandomValues) { |
There was a problem hiding this comment.
Can you change this to isUndefined(crypto) ?
There was a problem hiding this comment.
no problem, did not see that function up there
|
This looks awesome! I'm going to test this out later before merging. |
|
do you need any further work on this one? |
mattrobenolt
added a commit
that referenced
this pull request
Jun 29, 2015
Use window.crypto for uuid4 if present
|
@matteosimone Sorry about that, I verified this in modern Chrome/Firefox, but didn't touch it in IE. I'm going to assume it's ok since nobody suggested otherwise when I asked. :) Thanks. 🍰 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing issue #340