-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
ref(node): Refactor node source fetching into integration #3729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(node): Refactor node source fetching into integration #3729
Conversation
I like this approach much better. One thing that we might try though is to go even further and move context lines to a separate integration and add it by default. I already implemented it in |
This comment has been minimized.
This comment has been minimized.
That's definitely a valid concern, although with a 100 items cache it should be a very minor if any performance issue. wdyt @rhcarvalho @HazAT |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
I promise, I do intend to finish this when I'm back from my extended vacation. |
@lobsterkatie maybe you can advise on these nextjs test failures? From what I can tell, it's completely expected for I'm not quite sure why my changes have caused this to start failing 🤔. |
03cb320
to
e08bcbb
Compare
…fish/sentry-javascript into feat/separate-source-reading
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to be a good change!
Seems like you figured it out, but LMK if you still need help! |
Yep worked it out in the end. Thanks for the code review. This theoretically means that a load of async can be removed from the browser/node SDKs because it was only there to cater for the node code context loading! |
/** | ||
* Sets the number of context lines for each frame when loading a file. | ||
* | ||
* @deprecated Context lines configuration has moved to the `ContextLines` integration, and can be used like this: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍. We'll need to update docs for this as well.
09f27da
to
ef7d423
Compare
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can only merge once we have the docs PR ready to go
Docs PR done 🎉🎉🎉 |
This PR:
eventFromException
andeventFromMessage
intoeventbuilder
to match browser SDKContextLines
integrationframeContextLines
option gets copied toContextLines
constructor but also pullsframeContextLines
fromNodeOptions
to avoid a breaking change.frameContextLines
inNodeOptions
marked as@deprecated
so users learn about future migration