Refactor makeRequest to prepare to be overridden #379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| function makeRequest(data) { | ||
| var img, | ||
| src; | ||
| var url = globalServer + authQueryString; |
There was a problem hiding this comment.
This is the only part that I'm not super happy about.
I think the transport should get another auth key with all the pieces. If we send this as a form or XHR, I assume we wouldn't want them to be a part of the querystring, correct?
/cc @dcramer
There was a problem hiding this comment.
auth should def be something passed into the callback and the default callback would just be responsible for changing the querystring
There was a problem hiding this comment.
Yeah, was leaning towards that. Updating...
|
👍 |
mattrobenolt
force-pushed
the
refactor
branch
from
dbd5695 to
2e4a92c
Compare
mattrobenolt
added a commit
that referenced
this pull request
Sep 15, 2015
Refactor makeRequest to prepare to be overridden
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should be noop, but it will lay the necessary groundwork to just provide a
transportoption (name tbd).I just want to make sure this is ok internally before we expose the ability to override this externally.
Refs #183 #335
/cc @benvinegar @dcramer