fix(core): Skip native frames while searching frame URLs. #3897
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the exceptions are thrown from native code (see To reproduce below),
InboundFilters#_getLastValidUrl()
returns[native code]
instead of a valid URL, causingInboundFilters#_isAllowedUrl()
fail.This PR skips native frames to solve the issue.
Package + Version
@sentry/browser@6.11.0
To reproduce
Visit https://codepen.io/luin/pen/qBmGgwv on Safari. It contains a regexp that Safari doesn't support. The error stack will show on the alert box. Notice that the first frame is
[native code]
.yarn lint
) & (yarn test
).