test(node): Add basic integration tests for Express. #4817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onurtemizkan
force-pushed
the
onur/add-basic-express-int-tests
branch
from
72267bb to
62a5f44
Compare
AbhiPrasad
reviewed
Mar 29, 2022
| Sentry.init({ | ||
| dsn: 'https://public@dsn.ingest.sentry.io/1337', | ||
| release: '1.0', | ||
| integrations: [new Sentry.Integrations.Http({ tracing: true }), new Tracing.Integrations.Express({ app })], |
There was a problem hiding this comment.
Can we also check if outgoing requests get the sentry trace header attached? Would also like to see the opposite, an incoming request get a transaction created based on the incoming sentry-trace header.
There was a problem hiding this comment.
@AbhiPrasad, I added the tests. Kind of hacky though.
There was a problem hiding this comment.
This is fine as a starting point, we can always improve afterwards
… into onur/add-basic-express-int-tests
AbhiPrasad
approved these changes
Mar 31, 2022
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #4762
These tests are very basic and roughly check if error handling and transactions are not broken on Express.