Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(migration): Add section for renaming of CDN bundles #4918

Merged
merged 2 commits into from
Apr 12, 2022
Merged

docs(migration): Add section for renaming of CDN bundles #4918

merged 2 commits into from
Apr 12, 2022

Conversation

lforst
Copy link
Member

@lforst lforst commented Apr 12, 2022

Add section in MIGRATION.md explaining CDN bundle renaming in v7.

Ref: https://getsentry.atlassian.net/browse/WEB-683

@lforst lforst changed the base branch from master to 7.x April 12, 2022 08:24
@lforst lforst added this to the 7.0.0 milestone Apr 12, 2022
Lms24
Lms24 approved these changes Apr 12, 2022
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one remark - feel free to make (no) adjustments as necessary

MIGRATION.md Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Apr 12, 2022 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.11 KB (-0.17% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 65.46 KB (+1.32% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.81 KB (-0.27% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 58.69 KB (+1.26% 🔺)
@sentry/browser - Webpack (gzipped + minified) 23.13 KB (-0.45% 🔽)
@sentry/browser - Webpack (minified) 82.66 KB (+1.16% 🔺)
@sentry/react - Webpack (gzipped + minified) 23.17 KB (-0.45% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.95 KB (-0.21% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.06 KB (-0.04% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.46 KB (-0.1% 🔽)

@lforst @Lms24
Update MIGRATION.md
7649c35 
Include review feedback

Co-authored-by: Lukas Stracke <lukas@stracke.co.at>
@lforst lforst merged commit 58b9c4e into 7.x Apr 12, 2022
@lforst lforst deleted the lforst-migration-guide-cdn-bundles branch April 12, 2022 08:54
lobsterkatie pushed a commit that referenced this pull request Apr 13, 2022
@lforst @Lms24 @lobsterkatie
docs(migration): Add section for renaming of CDN bundles (#4918)
d9ee071 
Co-authored-by: Lukas Stracke <lukas@stracke.co.at>
@lforst lforst mentioned this pull request Apr 21, 2022
Merged
Lms24 added a commit that referenced this pull request Apr 26, 2022
@lforst @Lms24
docs(migration): Add section for renaming of CDN bundles (#4918)
a2e7476 
Co-authored-by: Lukas Stracke <lukas@stracke.co.at>
lobsterkatie pushed a commit that referenced this pull request Apr 26, 2022
@lforst @Lms24 @lobsterkatie
feat(docs): Add section for renaming of CDN bundles (#4918)
cd46d3c 
Co-authored-by: Lukas Stracke <lukas@stracke.co.at>
lobsterkatie pushed a commit that referenced this pull request Apr 26, 2022
@lforst @Lms24 @lobsterkatie
feat(docs): Add section for renaming of CDN bundles (#4918)
43cb4a1 
Co-authored-by: Lukas Stracke <lukas@stracke.co.at>
AbhiPrasad pushed a commit that referenced this pull request May 30, 2022
@lforst @Lms24 @AbhiPrasad
feat(docs): Add section for renaming of CDN bundles (#4918)
b66851f 
Co-authored-by: Lukas Stracke <lukas@stracke.co.at>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

@lobsterkatie lobsterkatie Awaiting requested review from lobsterkatie

@AbhiPrasad AbhiPrasad Awaiting requested review from AbhiPrasad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lforst @Lms24