Skip to content

ref(core): Remove unnecessary nested dropUndefinedKeys call #5161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2022

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented May 24, 2022

This very small PR removes an unnecessary nested call to dropUndefinedKeys which we don't need because the function is already recursive (which could be causing a problem).

@Lms24 Lms24 requested a review from lforst May 24, 2022 14:52
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.32 KB (-4.05% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 59.89 KB (-7.31% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.18 KB (-3.63% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 53.58 KB (-7.58% 🔽)
@sentry/browser - Webpack (gzipped + minified) 19.87 KB (-14.5% 🔽)
@sentry/browser - Webpack (minified) 63.02 KB (-22.88% 🔽)
@sentry/react - Webpack (gzipped + minified) 19.89 KB (-14.54% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified) 43.71 KB (-9.04% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 25.34 KB (-2.81% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 23.9 KB (-2.4% 🔽)

@Lms24 Lms24 merged commit ef9a5d9 into 7.x May 25, 2022
@Lms24 Lms24 deleted the lms-remove-nested-dropundefinedkeys branch May 25, 2022 07:13
AbhiPrasad pushed a commit that referenced this pull request May 30, 2022
remove an unnecessary nested call to dropUndefinedKeys which we don't need because the function is already recursive.
@AbhiPrasad AbhiPrasad added this to the 7.0.0 milestone May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants