fix(utils): Fix infinite recursion in dropUndefinedKeys
#5163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
Lms24
approved these changes
May 25, 2022
packages/utils/src/object.ts
Outdated
Comment on lines
208
to
210
| * Works recursively on objects and arrays. | ||
| */ | ||
| export function dropUndefinedKeys<T>(val: T): T { |
There was a problem hiding this comment.
Small nit: Should we update the JSDoc and mention that the function handles circular references?
There was a problem hiding this comment.
Yup, thanks. Added comment describing what the function does with circ refs - whis is also implying that it handles circ refs ^^ -> 4429b64
3 tasks
AbhiPrasad
pushed a commit
that referenced
this pull request
May 30, 2022
This was referenced Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets rid of infinite recursion in
dropUndefinedKeyswhen passing objects/arrays with circular references.Reported in #2470 (comment)