fix(ember): Restore ember package contents #5318
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description
As reported in #5296, from version
7.1.1
to7.2.0
of the Ember SDK, a majority of the contents of the npm packages suddenly disappeared.We traced the issue back to a Node.js dependency change (in patch
v16.15.1
) that bumped npm from version8.5.5
to8.11.0
. That npm version bump included a fix (npm/cli#4917 & npm/npm-packlist#102, first appeared in npmv8.11.0
) that restores the functionality thatnpm pack
also looks at workspace roots for.npmignore
files. For the ember SDK package, we actually depended on the bug that is now fixed, as a result messing up our package contents.Changes
To fix the ember package contents we simply override the workspace root
.npmignore
rules in the.npmignore
file of the ember package. Essentially, for the ember package, this now works as if there were no.npmignore
file in the workspace root.Additionally, as of this PR, we pin the default node version (and implicitly the npm version). So we have reproducible builds.
Fixes #5296