Skip to content

fix(remix): Clone erroneous responses not to consume their body streams. #5429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lobsterkatie merged 1 commit into from
Jul 21, 2022
Merged

fix(remix): Clone erroneous responses not to consume their body streams. #5429

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/remix/src/utils/instrumentServer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,16 +84,19 @@ function isResponse(value: any): value is Response {
);
}

// Taken from Remix Implementation
// Based on Remix Implementation
// https://github.com/remix-run/remix/blob/7688da5c75190a2e29496c78721456d6e12e3abe/packages/remix-server-runtime/data.ts#L131-L145
function extractData(response: Response): Promise<unknown> {
const contentType = response.headers.get('Content-Type');

// Cloning the response to avoid consuming the original body stream
const responseClone = response.clone();

if (contentType && /\bapplication\/json\b/.test(contentType)) {
return response.json();
return responseClone.json();
}

return response.text();
return responseClone.text();
}

function captureRemixServerException(err: Error, name: string): void {
Expand Down