test(svelte): Add Svelte Testing Library and trackComponent tests #5686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
commented
Sep 2, 2022
| jest.resetAllMocks(); | ||
| testTransaction.spans = []; | ||
|
|
||
| testTransaction.startChild.mockImplementation(spanCtx => { |
There was a problem hiding this comment.
Sometimes, Jest is a mystery to me. Apparently, mockImplementation (or mockReturnValue) must be called inside a describe or it/test function, while I can create empty jest.fn() mocks anywhere. I find this a little weird but whatever
Lms24
force-pushed
the
lms-svelte-testing-library
branch
from
beaf0f1 to
3efa16d
Compare
Lms24
force-pushed
the
lms-svelte-testing-library
branch
from
d3bf11f to
30311ef
Compare
lforst
approved these changes
Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Svelte Testing Library to the Svelte SDK. More specifically, two dev dependencies:
@testing-library/sveltewhich lets us test Svelte componentssvelte-jesterwhich is responsible to transform Svelte components to JS in Jest testsThe nice thing about this is that Svelte Testing Library offers us a way to simulate the rendering and mounting process of Svelte components. This means that we can properly test the
trackComponentfunction without having to manually go in and simulate life cycle hooks calls. While in #5612, we added tests for the component tracking preprocessor, we didn't add tests for the actual tracking implementation.Therefore, this PR also adds a bunch of test for
trackComponent. I think this especially valuable because it is also public API and users can manually call this function if they don't want to use our preprocessor.ref: #5671