fix(nextjs): Handle pathname being passed in object in instrumentServer
#5782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lforst
reviewed
Sep 21, 2022
| const wrappedMethod = async function (this: Server, parameterizedPath: string, ...args: any[]): Promise<any> { | ||
| const wrappedMethod = async function ( | ||
| this: Server, | ||
| parameterizedPath: string | { pathname: string }, |
There was a problem hiding this comment.
I think we should add a comment here explaining that the two different types come from two different nextjs versions.
lforst
approved these changes
Sep 21, 2022
lobsterkatie
force-pushed
the
kmclb-nextjs-fix-path-parameterization-in-instrument-server
branch
from
4497932 to
9582902
Compare
lobsterkatie
deleted the
kmclb-nextjs-fix-path-parameterization-in-instrument-server
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In nextjs version 12.2.6, the signature of
findPageComponentswhich we wrap ininstrumentServerchanged, from accepting individual parameters to accepting an options object. This changes our wrapping to accommodate that, and as a result fixes transactions started byinstrumentServerbeing parameterized as[ object Object ]. For backwards compatibility with older versions of next, individual parameters also continue to be accepted.