Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tracing): Remove connection.downlink measurement #5794

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

AbhiPrasad
Copy link
Member

As per RFC: https://github.com/getsentry/rfcs/blob/main/text/0003-browser-js-built-in-metrics.md we have decided to remove connection.downlink from as a recorded performance metrics in the BrowserTracing integration

As per RFC: https://github.com/getsentry/rfcs/blob/main/text/0003-browser-js-built-in-metrics.md
we have decided to remove `connection.downlink` from as a recorded
performance metrics in the BrowserTracing integration
@AbhiPrasad AbhiPrasad requested review from a team, lforst and Lms24 and removed request for a team September 22, 2022 11:52
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.47 KB (+0.02% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 60.16 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.06 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified) 53.08 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 19.85 KB (0%)
@sentry/browser - Webpack (minified) 64.49 KB (0%)
@sentry/react - Webpack (gzipped + minified) 19.88 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 44.71 KB (-0.06% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 25.92 KB (-0.08% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.31 KB (-0.08% 🔽)

@AbhiPrasad AbhiPrasad merged commit d6bcb47 into master Sep 22, 2022
@AbhiPrasad AbhiPrasad deleted the abhi-connection-downlink branch September 22, 2022 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants