Skip to content

ref(nextjs): Simplify rollupize in proxy loader #6020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 24, 2022

Conversation

lobsterkatie
Copy link
Member

This makes a few small changes to the rollupize function used by the nextjs SDK's proxy loader:

  • Consolidate error handling in the proxy loader, rather than handling errors inside of rollupize and then handling an undefined rollupize return value in the proxy loader.
  • Slightly simplify explanation of makeAbsoluteExternalsRelative
  • Remove type hack in getRollupInputOptions which seems no longer to be needed. (It was never clear why it was necessary in the first place, and TS no longer seems mad when it's removed.)
  • Rename resourcePath to userModulePath for clarity

The latter two changes are drawn from #5960, to preserve them even though it is being reverted.

@lobsterkatie lobsterkatie merged commit 233c9e6 into master Oct 24, 2022
@lobsterkatie lobsterkatie deleted the kmclb-nextjs-simplify-rollupize-in-proxy-loader branch October 24, 2022 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants