ref(replay): Avoid overwriting user checkoutEveryNms config
#6454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billyvg
approved these changes
Dec 7, 2022
AbhiPrasad
approved these changes
Dec 7, 2022
size-limit report 📦
|
mydea
force-pushed
the
fn/avoid-setting-recording-options
branch
from
1466c2c to
37a81d6
Compare
AbhiPrasad
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes how we overwrite
checkoutEveryNmsconfig when sampling for errors. This is a bit cleaner and also ensures we do not loose this setting in regular replay sampling if the user specified it. I also extended on the comment for added clarity why this exists.note: If #6448 is merged first, need to adjust accordingly as that is moved a bit.