Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(nextjs): Add NextJS server-side E2E tests. #6829

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

onurtemizkan
Copy link
Collaborator

Ref: #6292

  • Added 2 server-side behaviour tests in the create-next-app test application.

  • This set of tests use Playwright as their runner, but they don't use the browser functionality of it. This is for simplicity and also consistency, as expect.poll is not available in jest runners.

  • Not sure triggering a server-side error through a user interaction on browser will make a difference for E2E tests, but it's also an option with this setup.

  • The event/transaction ids are returned to the test environment as HTTP responses from the server.

  • If the team agrees, this approach has a potential to be generalised while writing other server-side tests. Not updating README for now.

@onurtemizkan onurtemizkan force-pushed the onur/next-e2e-server-tests branch from 3699745 to 1f91ad2 Compare January 17, 2023 17:30
@onurtemizkan onurtemizkan requested a review from lforst January 17, 2023 17:31
@github-actions
Copy link
Contributor

github-actions bot commented Jan 17, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.82 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 61.47 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.5 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified) 54.77 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.21 KB (0%)
@sentry/browser - Webpack (minified) 66.17 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.24 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.48 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.74 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.03 KB (+0.01% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 43.12 KB (-0.83% 🔽)
@sentry/replay - Webpack (gzipped + minified) 37.83 KB (-1.01% 🔽)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 60.37 KB (-0.6% 🔽)

@onurtemizkan onurtemizkan force-pushed the onur/next-e2e-server-tests branch 2 times, most recently from 8715ff5 to 5bf058a Compare January 17, 2023 17:46
@onurtemizkan onurtemizkan self-assigned this Jan 17, 2023
@onurtemizkan onurtemizkan force-pushed the onur/next-e2e-server-tests branch from 5bf058a to 565bb80 Compare January 18, 2023 16:25
Copy link
Member

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I like the the approach of just using the playwright runner 👍

@lforst lforst merged commit d1ddeff into master Jan 23, 2023
@lforst lforst deleted the onur/next-e2e-server-tests branch January 23, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants