Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: CHANGELOG for 7.33.0 #6920

Merged
merged 3 commits into from
Jan 24, 2023
Merged

meta: CHANGELOG for 7.33.0 #6920

merged 3 commits into from
Jan 24, 2023

Conversation

lforst
Copy link
Member

@lforst lforst commented Jan 24, 2023

No description provided.

@lforst lforst requested review from mydea, Lms24 and AbhiPrasad January 24, 2023 15:44
CHANGELOG.md Outdated
@@ -4,6 +4,12 @@

- "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott

## 7.32.2
Copy link
Member

@Lms24 Lms24 Jan 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd vote this should be a minor as removing default sample rates in Replay is quite an important change.

Suggested change
## 7.32.2
## 7.33.0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. I also added a note explaining the change.

@lforst lforst changed the title meta: CHANGELOG for 7.32.2 meta: CHANGELOG for 7.33.0 Jan 24, 2023
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the sentence about Replay ❤️

@lforst lforst merged commit 67e4c2b into master Jan 24, 2023
@lforst lforst deleted the lforst-changelog-7.32.2 branch January 24, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants