Skip to content

Don't assume previous shouldSendCallback exists in RN plugin (fixes #692) #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2016
Merged

Don't assume previous shouldSendCallback exists in RN plugin (fixes #692) #694

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d356dfd
Don't assume previous shouldSendCallback exists in RN plugin (fixes #…
benvinegar Aug 18, 2016
46b99da
Return true if originalCallback isn't specified
benvinegar Aug 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion plugins/react-native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,8 @@ function reactNativePlugin(Raven, options) {

Raven.setShouldSendCallback(function(data, originalCallback) {
if (!(FATAL_ERROR_KEY in data)) {
return originalCallback.call(this, data);
// not a fatal (will not crash runtime), continue as planned
return originalCallback ? originalCallback.call(this, data) : true;
}

var origError = data[FATAL_ERROR_KEY];
Expand Down