feat(nextjs): Improve client stack traces #7097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
reviewed
Feb 8, 2023
Trust me it works |
size-limit report 📦
|
|
@AntonBurduzha fyi |
Replay SDK metrics 🚀
develop |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Revision | LCP | CLS | CPU | JS heap avg | JS heap max | netTx | netRx | netCount | netTime |
|---|---|---|---|---|---|---|---|---|---|
| 5c937aa | +55.49 ms | +0.00 ms | +14.47 pp | +1.08 MB | +2.22 MB | +2.61 kB | +41 B | +1 | +68.14 ms |
| 45638e4 | +71.80 ms | +0.00 ms | +21.94 pp | +1.1 MB | +2.26 MB | +2.61 kB | +41 B | +1 | +98.15 ms |
| b539b36 | +53.97 ms | -0.00 ms | +16.53 pp | +1.12 MB | +2.23 MB | +2.61 kB | +41 B | +1 | +114.29 ms |
| 6462b00 | +62.18 ms | +0.00 ms | +23.70 pp | +1.1 MB | +2.23 MB | +2.57 kB | +41 B | +1 | +117.17 ms |
*) pp - percentage points - an absolute difference between two percentages.
Last updated: Thu, 09 Feb 2023 09:39:01 GMT
Last updated: Thu, 09 Feb 2023 09:39:01 GMT
|
@AbhiPrasad I caved and added tests and only potentially discovered an edge case lol |
|
AbhiPrasad
approved these changes
Feb 9, 2023
| if ( | ||
| frame.filename && | ||
| frame.filename.match( | ||
| /^app:\/\/\/_next\/static\/chunks\/(main-|main-app-|polyfills-|webpack-|framework-|framework\.)[0-9a-f]+\.js$/, |
There was a problem hiding this comment.
will this have any possible issues with windows paths?
There was a problem hiding this comment.
It's just on the client so we're good
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading this blog post we should probably do what they're doing out of the box: https://hackernoon.com/how-to-upload-source-maps-to-sentry-with-nextjs
Also marks Next.js internal frames with
in_app: falsebecause users shouldn't care about those.