Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nextjs): Instrument app dir route handlers #7369

Closed
wants to merge 28 commits into from

Conversation

lforst
Copy link
Member

@lforst lforst commented Mar 7, 2023

Ref #7228

Instruments Next.js app dir route handlers. We add two new utility functions wrapRequestHandlerLikeFunctionWithErrorInstrumentation and wrapRequestHandlerLikeFunctionWithPerformanceInstrumentation that we immediately use to wrap the route handlers. It is planned that we migrate to these wrappers for all other Next.js functions (data-fetchers, API routes, etc.).

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.41 KB (+0.03% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 63.33 KB (+0.05% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.99 KB (+0.03% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 56.25 KB (+0.06% 🔺)
@sentry/browser - Webpack (gzipped + minified) 20.67 KB (+0.09% 🔺)
@sentry/browser - Webpack (minified) 67.55 KB (+0.17% 🔺)
@sentry/react - Webpack (gzipped + minified) 20.69 KB (+0.09% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 52.11 KB (+0.04% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 33.66 KB (+0.03% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.01 KB (+0.03% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 43.18 KB (+0.03% 🔺)
@sentry/replay - Webpack (gzipped + minified) 37.19 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 61.31 KB (+0.02% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 54.39 KB (+0.02% 🔺)

@lforst lforst changed the title feat(nextjs): Add wrapper for app dir route handlers feat(nextjs): Instrument app dir route handlers Mar 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@github-actions
Copy link
Contributor

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@lforst
Copy link
Member Author

lforst commented Aug 28, 2023

Superseded by #8832

@lforst lforst closed this Aug 28, 2023
@lforst lforst deleted the lforst-nextjs-app-dir-route-handler branch December 3, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants