-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(replay): Add replay E2E test #7486
Conversation
size-limit report 📦
|
e382d87
to
71bfaa6
Compare
}, | ||
{ | ||
type: 3, | ||
data: { source: 5, text: 'Capture Exception', isChecked: false, id: 16 }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not quite sure where this text
comes from.. tried to replicate this in rrweb but couldn't. We should look into why this is not masked!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I would not block this PR on this, though)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm It doesn't look like a html element text, right? Maybe a console log?
But yeah, I agree, it shouldn't block this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it is related to what they pointed out here:
rrweb-io/rrweb#1164 (comment)
I will investigate this further!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, good idea to just add it to an existing test setup!
packages/e2e-tests/test-applications/standard-frontend-react/tests/behaviour-test.spec.ts
Outdated
Show resolved
Hide resolved
}, | ||
{ | ||
type: 3, | ||
data: { source: 5, text: 'Capture Exception', isChecked: false, id: 16 }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm It doesn't look like a html element text, right? Maybe a console log?
But yeah, I agree, it shouldn't block this PR
Also a note: If we find this to become unstable and flaky in the future, we may have to rewrite the snapshot checking stuff. For now it appeared stable enough to me, but we'll see - just FYI! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
7ef34f6
to
2353335
Compare
…ests/behaviour-test.spec.ts Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
2353335
to
aa5030c
Compare
This adds replay to one of our E2E test apps and also verifies that the replay is correctly sent over.
Closes #7249