Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(replay): Add replay E2E test #7486

Merged
merged 4 commits into from
Mar 23, 2023
Merged

test(replay): Add replay E2E test #7486

merged 4 commits into from
Mar 23, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Mar 16, 2023

This adds replay to one of our E2E test apps and also verifies that the replay is correctly sent over.

Closes #7249

@mydea mydea self-assigned this Mar 16, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.57 KB (+0.64% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 64.19 KB (+1.06% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.13 KB (+0.01% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 56.57 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 21.59 KB (0%)
@sentry/browser - Webpack (minified) 71.65 KB (0%)
@sentry/react - Webpack (gzipped + minified) 21.61 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 51.85 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 27.9 KB (+0.47% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.08 KB (+0.01% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 44.3 KB (+0.01% 🔺)
@sentry/replay - Webpack (gzipped + minified) 38.36 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 62.49 KB (-0.01% 🔽)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 56.03 KB (+0.01% 🔺)

@mydea mydea force-pushed the fn/replay-e2e-test branch 6 times, most recently from e382d87 to 71bfaa6 Compare March 20, 2023 11:20
@mydea mydea requested review from Lms24 and billyvg March 20, 2023 11:54
@mydea mydea marked this pull request as ready for review March 20, 2023 11:54
},
{
type: 3,
data: { source: 5, text: 'Capture Exception', isChecked: false, id: 16 },
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not quite sure where this text comes from.. tried to replicate this in rrweb but couldn't. We should look into why this is not masked!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I would not block this PR on this, though)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm It doesn't look like a html element text, right? Maybe a console log?

But yeah, I agree, it shouldn't block this PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it is related to what they pointed out here:
rrweb-io/rrweb#1164 (comment)

I will investigate this further!

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, good idea to just add it to an existing test setup!

},
{
type: 3,
data: { source: 5, text: 'Capture Exception', isChecked: false, id: 16 },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm It doesn't look like a html element text, right? Maybe a console log?

But yeah, I agree, it shouldn't block this PR

@mydea
Copy link
Member Author

mydea commented Mar 20, 2023

Also a note: If we find this to become unstable and flaky in the future, we may have to rewrite the snapshot checking stuff. For now it appeared stable enough to me, but we'll see - just FYI!

Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@mydea mydea force-pushed the fn/replay-e2e-test branch from 7ef34f6 to 2353335 Compare March 22, 2023 11:30
@mydea mydea force-pushed the fn/replay-e2e-test branch from 2353335 to aa5030c Compare March 22, 2023 15:55
@mydea mydea merged commit 551aedc into develop Mar 23, 2023
@mydea mydea deleted the fn/replay-e2e-test branch March 23, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add replay E2E test
3 participants