Skip to content

feat(remix): Remove @sentry/tracing dependency from Remix SDK #7575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 22, 2023

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Mar 22, 2023

  • In index.client.tsx, BrowserTracing and Integrations are passed through from @sentry/react
  • In index.server.ts:
    • @sentry/node already exports Integrations which includes both node and tracing integrations
    • Previously, node Integrations were hidden due to the tracing Integrations export
    • ⚠️ BrowserTracing is no longer exported. This is technically a breaking change but I don't think it should have ever been exported from the server.

@timfish timfish marked this pull request as ready for review March 22, 2023 18:19
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on BrowserTracing in the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants