ref(nextjs): Use @sentry/vercel-edge in nextjs package #9053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 19, 2023
lforst
approved these changes
Sep 20, 2023
Lms24
approved these changes
Sep 20, 2023
There was a problem hiding this comment.
Also LGTM from my PoV. Adjusted e2e and integration tests.
A slight change that shouldn't have much effect on in-product features is that the event contexts.runtime changes from edge to vercel-edge. Just noting it here for future readers.
RE publishing vs inlining: The advantage of publishing the package is that other, non-NextJS users can try the package. We previously marked it as alpha state so if we need to break things, we can.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #8087
Dependent on #9051 merging in