Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(feedback): Bootstrap feedback integration #9139

Merged
merged 19 commits into from
Oct 16, 2023
Merged

feat(feedback): Bootstrap feedback integration #9139

merged 19 commits into from
Oct 16, 2023

Conversation

c298lee
Copy link
Contributor

@c298lee c298lee commented Sep 28, 2023

Integrate feedback into sdk

@c298lee c298lee requested a review from billyvg September 28, 2023 20:38
mydea
mydea reviewed Sep 29, 2023
View reviewed changes
mydea
mydea reviewed Sep 29, 2023
View reviewed changes
packages/feedback/jest.setup.ts Outdated
@@ -0,0 +1,272 @@
/* eslint-disable @typescript-eslint/no-unsafe-member-access */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file we prob. don't need here as well

@c298lee c298lee force-pushed the feat-feedback-bootstrap-feedback-integration branch from 11ebf5f to 2fc93b0 Compare September 29, 2023 19:37
@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2023 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 83.98 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.57 KB (0%)
@sentry/browser - Webpack (gzipped) 21.75 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 80.47 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 29.51 KB (+0.01% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 21.69 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 245.55 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 85.53 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 61.45 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 32.64 KB (+0.01% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 84.05 KB (0%)
@sentry/react - Webpack (gzipped) 21.79 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 102.18 KB (0%)
@sentry/nextjs Client - Webpack (gzipped) 49.65 KB (0%)

@billyvg billyvg force-pushed the feat-feedback-bootstrap-feedback-integration branch 2 times, most recently from 3063b07 to f71e413 Compare September 29, 2023 20:49
@billyvg billyvg marked this pull request as ready for review October 13, 2023 18:52
@billyvg billyvg mentioned this pull request Oct 13, 2023
Merged
AbhiPrasad
AbhiPrasad reviewed Oct 13, 2023
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we aiming to publish this next release? If so we should update the craft.yml here as well.

packages/feedback/README.md
## Installation

Feedback can be imported from `@sentry/browser`, or a respective SDK package like `@sentry/react` or `@sentry/vue`.
You don't need to install anything in order to use Feedback. The minimum version that includes Feedback is <<CHANGEME>>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: Is this still todo?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah still TODO until we add it to core

packages/feedback/package.json Outdated
"homepage": "https://docs.sentry.io/platforms/javascript/",
"devDependencies": {
"@babel/core": "^7.17.5",
"tslib": "^2.4.1 || ^1.9.3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the babel dev dep? I also think tslib needs to be a regular dependency.

@billyvg
Copy link
Member

billyvg commented Oct 16, 2023

@AbhiPrasad This won't be published with main SDK pkgs for now, will just be published to the sentry-internal namespace.

AbhiPrasad
AbhiPrasad approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it!!

@billyvg billyvg force-pushed the feat-feedback-bootstrap-feedback-integration branch from 06d85ca to 4b3edc2 Compare October 16, 2023 16:32
@billyvg billyvg merged commit 6921f06 into develop Oct 16, 2023
@billyvg billyvg deleted the feat-feedback-bootstrap-feedback-integration branch October 16, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billyvg billyvg billyvg approved these changes

@mydea mydea mydea left review comments

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@c298lee @billyvg @mydea @AbhiPrasad