Skip to content

Conversation

@timfish
Copy link
Collaborator

@timfish timfish commented Oct 19, 2023

Ref #9199

This PR vendors the cookie module. I simplified the code a little since we don't use the options parameter.

@AbhiPrasad AbhiPrasad merged commit 7236510 into getsentry:develop Oct 19, 2023
@timfish timfish deleted the feat/vendor-cookie-module branch October 19, 2023 17:28
@alfaproject
Copy link

Ehhhh, we actually use cookie as well, so now we basically have 2 copies of almost the same code? Was this really necessary?

@AbhiPrasad
Copy link
Member

@alfaproject please see https://develop.sentry.dev/sdk/philosophy/#dependencies-cost - we try to avoid using deps in our SDK as much as possible.

@alfaproject
Copy link

Except in this case you didn't avoid anything, you literally cloned it. Pretty much every Express user out there will have this code duplicated. Oh well, thanks for the info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants