fix(astro): Convert init file paths to POSIX paths #9336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
changed the title
aldy505
approved these changes
Oct 23, 2023
AbhiPrasad
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To inject a custom client/server Sentry.init call into the user bundles, we simply import from the file.
However, it seems like Vite can't resolve an absolute windows path in an import statement:
This PR converts non-posix paths to a POSIX conforming path first which should fix this limitation. This bug was reported on Discord and I asked to user to test the fix in their local setup which they confirmed to be working.
Note: Omitted tests here because it's quite hard to get
path.septo return the actual windows\\separator instead of the OS one. Can revisit if reviewers prefer to have this properly covered.