Skip to content

Conversation

@lforst
Copy link
Contributor

@lforst lforst commented Oct 24, 2023

Fixes a bug where we didn't use the release value passed to the webpack plugin to inject release values into the bundle, essentially causing the release values to drift apart causing a plethora of issues:

  • no sourcemapping
  • countless "phantom" releases
  • missassociation of issues

@lforst lforst requested review from AbhiPrasad, Lms24 and mydea October 24, 2023 13:46
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 82.66 KB (+0.18% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 71.77 KB (+0.16% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 30.94 KB (+0.95% 🔺)
@sentry/browser - Webpack (gzipped) 21.26 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 73.03 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 28.93 KB (+0.78% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 21.09 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 233.81 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 87.77 KB (+0.77% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 62.76 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.71 KB (+0.81% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 83.05 KB (+0.09% 🔺)
@sentry/react - Webpack (gzipped) 21.29 KB (+0.03% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 99.43 KB (+0.05% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 47.83 KB (+0.58% 🔺)

@lforst lforst merged commit f6d66b5 into develop Oct 24, 2023
@lforst lforst deleted the lforst-fix-broken-release-passing branch October 24, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants