Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nextjs): Trace errors in page component SSR #9388

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

lforst
Copy link
Member

@lforst lforst commented Oct 27, 2023

This will attach errors happening while serverside rendering page components to the corresponding transaction.

Resolves #9152

Note: Ideally we would have a span for rendering the page and attach the error there but this would be messy to do with our current implementation. The reason is that we cannot directly grab the request transaction from within the render function because it doesn't live in the current async context. We would have to pass references or keys around and clean them up after a response has been sent so the transactions can be GCd. The mess would originate from the fact that we create spans and transactions differently depending on whether we're in a lambda environment.

We will do span creation in a follow-up PR.

@lforst lforst force-pushed the lforst-nextjs-trace-page-component-errors branch from a4bef18 to 5ba7ec0 Compare October 27, 2023 10:28
@lforst lforst force-pushed the lforst-nextjs-trace-page-component-errors branch from 5ba7ec0 to 0225982 Compare October 27, 2023 10:56
@lforst lforst marked this pull request as ready for review October 27, 2023 10:57
@lforst lforst changed the title feat(nextjs): Trace errors in page components feat(nextjs): Trace errors in page component SSR Oct 27, 2023
@lforst lforst merged commit 78e61ff into develop Oct 27, 2023
52 checks passed
@lforst lforst deleted the lforst-nextjs-trace-page-component-errors branch October 27, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Next.js SSR unhandled errors are not logged
2 participants