feat(replay): Stop fixing truncated JSONs in SDK

[mydea]

This is potentially performance intensive, so we should just do this in the UI instead.

Part of #9426

We need to move the code that actually "fixes" the JSON to sentry. cc @ryan953

The logic should be:

If a request/response body has the MAYBE_JSON_TRUNCATED warning, try to run it through fixJson

try {
  const json =  fixJson(body);
  const normalizedBody = JSON.parse(json);
} catch {
  // always try-catch this as this may fail
  // if it fails, just use the string body as-is, and consider this as `INVALID_JSON`
}

Pending on getsentry/sentry#59266 to be merged

[github-actions]

size-limit report 📦

Path	Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)	65.2 KB (-1.07% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped)	55.44 KB (-1.27% 🔽)
@sentry/browser (incl. Tracing) - Webpack (gzipped)	30.97 KB (0%)
@sentry/browser - Webpack (gzipped)	21.29 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped)	61.78 KB (-1.07% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)	29.09 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped)	21.23 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed)	194.75 KB (-1.09% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed)	88.28 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed)	63.28 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)	31.8 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped)	65.56 KB (-1.07% 🔽)
@sentry/react - Webpack (gzipped)	21.34 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped)	82.3 KB (-0.81% 🔽)
@sentry/nextjs Client - Webpack (gzipped)	48.12 KB (0%)
@sentry-internal/feedback - Webpack (gzipped)	15.59 KB (0%)

[AbhiPrasad]

Don't we need the un-truncated JSON to do proper PII tripping? Is this something we can do in Relay?

[JonasBa]

Just a note. We need to make make sure the UI can do this efficiently so we don't end up just transferring the problem. If possible, I would look into reconstructing this on the server side or in Relay if necessary

[mydea]

pulling in @cmanallen from a slack conversation: PII stripping may be "overly" cautious, but we can tweak this server side a bit to allow partial PII stripping easier. We can also iterate on this over time.

note also that we only transfer a string if we exceed the max. length. Smaller payloads are still sent as POJO.

Just a note. We need to make make sure the UI can do this efficiently so we don't end up just transferring the problem. If possible, I would look into reconstructing this on the server side or in Relay if necessary

this is true! However, the problem is much smaller because you'll only look at a single body at a time, so the potential impact is much smaller. But with this implementation, we are also free to decide later to actually do that in relay - it's kind of abstracted away from the SDK (just needs to happen somewhere.

This is just the easiest implementation of this: getsentry/sentry#59266 but we can also do that elsewhere!