Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): Fix XHR instrumentation early return #9770

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Dec 7, 2023

This was introduced in #9542 😬

Ideally we could have a lint rule for this, but probably this is rather hard to do - so reminder to self to keep an eye out for this in the future!

Closes #9747

Note to reviewer(s): could you double check the file to make sure I didn't miss anything again? Just being cautious there...

Copy link
Member

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks right

Copy link
Contributor

github-actions bot commented Dec 7, 2023

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 74.66 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 66 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 59.6 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.13 KB (+0.03% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 29.74 KB (+0.04% 🔺)
@sentry/browser - Webpack (gzipped) 21.39 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 71.25 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 62.97 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 29.65 KB (+0.03% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 21.71 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 198.35 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 89.78 KB (+0.04% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 64.76 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 32.3 KB (+0.03% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 66.36 KB (+0.01% 🔺)
@sentry/react - Webpack (gzipped) 21.43 KB (+0.03% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 83.09 KB (+0.02% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 48.23 KB (+0.02% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 16.19 KB (0%)

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked and didn't find other similar early returns.

Yeah I guess we can't lint on returning void in a function that should return void 🤔

@mydea mydea merged commit da73a7a into develop Dec 7, 2023
92 checks passed
@mydea mydea deleted the fn/fix-xhr-setrequestheaders branch December 7, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to execute 'setRequestHeader' on 'XMLHttpRequest': The object's state must be OPENED.
3 participants