meta(eslint-config): Don't allow voiding Promises #9814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lforst Can you share an example? |
size-limit report 📦
|
mydea
reviewed
Dec 19, 2023
| }); | ||
| // This should never reject | ||
| // eslint-disable-next-line @typescript-eslint/no-floating-promises | ||
| this._worker.postMessage('clear'); |
There was a problem hiding this comment.
Alrighty, does this work? 06d041a
Lms24
approved these changes
Dec 19, 2023
@Lms24 I had the same thought but for some reason I couldn't get the eslint filtering rules to properly apply so I just said "screw it im ignoring all of these"... Let me try again. |
|
Ok I don't think this is is easily doable because eslintrcs look from the root and in "test packages" like e2e tests there are no test folders that we can match. Test folders and test files are already excluded from this rule. |
Lms24
approved these changes
Dec 19, 2023
anonrig
reviewed
Dec 19, 2023
| @@ -21,4 +21,5 @@ async function run(): Promise<void> { | |||
| } | |||
| } | |||
|
|
|||
| void run(); | |||
| // eslint-disable-next-line @typescript-eslint/no-floating-promises | |||
| run(); | |||
There was a problem hiding this comment.
Wdyt?
Suggested change
| run(); | |
| (async () => { await run() })(); |
There was a problem hiding this comment.
This will still create a floating promise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should be a bit more strict about floating promises in the SDK. Right now we're just slapping
voidon all of them which is a bit likets-ignore. Ideally, we are a bit more explicit about handling rejected promises or ignoring the lint rule with a description.This pr turns off the "void" option of the lint rule so that we become more explicit.