Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(replay): Change to use preset quality values #9903

Merged
merged 3 commits into from
Dec 19, 2023

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Dec 18, 2023

Instead of using canvas recording quality values direct to rrweb, use presets to control image quality and fps.

Closes https://github.com/getsentry/team-replay/issues/325

@billyvg billyvg force-pushed the feat-replay-add-canvas-recording-type-option branch from f7834db to 1da8803 Compare December 18, 2023 21:11
Copy link
Contributor

github-actions bot commented Dec 18, 2023

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 75.38 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 66.81 KB (+0.07% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 60.38 KB (+0.07% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.42 KB (0%)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 30.02 KB (0%)
@sentry/browser - Webpack (gzipped) 21.72 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 72.8 KB (+0.09% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 64.5 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 30.74 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 22.78 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 202.75 KB (+0.09% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 92.68 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 67.72 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 33.58 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 67.16 KB (+0.05% 🔺)
@sentry/react - Webpack (gzipped) 21.76 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 83.95 KB (+0.05% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 48.58 KB (0%)
@sentry-internal/feedback - Webpack (gzipped) 16.35 KB (0%)

@billyvg billyvg changed the title feat(replay): Add canvas.type setting feat(replay): Change to use preset quality values Dec 18, 2023
@billyvg billyvg marked this pull request as ready for review December 18, 2023 21:30
@billyvg billyvg requested a review from a team December 18, 2023 21:30
quality: 0.25,
},
},
normal: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd go with medium over normal here 🤔 but no strong feelings.

Instead of using canvas recording quality values direct to rrweb, use presets to control image quality and fps.

Closes getsentry/team-replay#325
@billyvg billyvg force-pushed the feat-replay-add-canvas-recording-type-option branch from 825f18d to 7acd14a Compare December 19, 2023 16:33
@billyvg billyvg enabled auto-merge (squash) December 19, 2023 20:32
@billyvg billyvg merged commit c85b2e4 into develop Dec 19, 2023
88 checks passed
@billyvg billyvg deleted the feat-replay-add-canvas-recording-type-option branch December 19, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants