Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): Add tests to SvelteKit 1.x E2E test app #9943

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Dec 20, 2023

This PR adds proper e2e tests to our Sveltekit 1.x test application.

Specifically we now test:

  1. Distributed pageload trace - important for browserTracing rework
  2. Distributed navigation trace - important for browserTracing rework
  3. Client side component error
  4. Client side universal load error
  5. Server side universal load error
  6. Server side server load error
  7. Server route/API error

Decided to revisit this PR to have a good base for the sveltekit part of #10387

I'll revisit #9944 as well to make sure SvelteKit 2.x is covered

@Lms24 Lms24 force-pushed the lms/test-sveltekit-add-e2e-test-cases branch 2 times, most recently from b3ae93f to 8fd1ff3 Compare December 21, 2023 10:04
@Lms24 Lms24 force-pushed the lms/test-sveltekit-add-e2e-test-cases branch from cc8ba58 to 07a3cb9 Compare January 12, 2024 10:16
@Lms24 Lms24 force-pushed the lms/test-sveltekit-add-e2e-test-cases branch from 07a3cb9 to 4d2a9cb Compare January 31, 2024 10:55
@Lms24 Lms24 marked this pull request as ready for review January 31, 2024 13:41
@Lms24 Lms24 requested review from lforst and mydea January 31, 2024 13:45
@Lms24 Lms24 merged commit 9fcbb84 into develop Jan 31, 2024
98 checks passed
@Lms24 Lms24 deleted the lms/test-sveltekit-add-e2e-test-cases branch January 31, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants