Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(node): Rework ANR to use worker script via an integration #9945

Merged
merged 38 commits into from
Dec 21, 2023
Merged

feat(node): Rework ANR to use worker script via an integration #9945

merged 38 commits into from
Dec 21, 2023

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Dec 20, 2023 •
edited
Loading

This is another attempt at #9823 since that broke build caching by writing to the source directory and had to be reverted.

This now runs the worker rollup build after the Node SDK transpile and overwrites the worker-script.js files in the build output.

timfish added 30 commits December 9, 2023 16:58
@timfish
feat(node): Use worker thread for ANR detection
ed4a316
@timfish
Remove utility
14fe3a5
@timfish
PR feedback
e5c82dd
@timfish
Merge branch 'develop' into fix/anr-worker-thread
d246581
@timfish
remove outdated comments
dce3684
@timfish
Merge remote-tracking branch 'origin/fix/anr-worker-thread' into fix/…
2ca69ca 
…anr-worker-thread
@timfish
use getWorkerThreads
3042553
@timfish
Merge branch 'develop' into fix/anr-worker-thread
dad68a1
@timfish
Merge branch 'develop' into fix/anr-worker-thread
61dd30f
@timfish
feat(node): Rework ANR to use worker script via an integration
33e1ce0
@timfish
Bodge the build and add platform
97b09bb
@timfish
also build before test
b2a1907
@timfish
Work on build
8b6289f
@timfish
Merge branch 'develop' into anr-worker-from-base64-script
0486f12
@timfish
Only node 16 😢
91c19b9
@timfish
Merge remote-tracking branch 'origin/anr-worker-from-base64-script' i…
26b4ebe 
…nto anr-worker-from-base64-script
@timfish
a few worker simplifications
d098a53
@timfish
PR review comments
27ebe02
@timfish
Merge remote-tracking branch 'upstream/develop' into anr-worker-from-…
624f097 
…base64-script
@timfish
Only test node >= 16
94af9ec
@timfish
Include and test the old deprecated API
40f25d2
@timfish
Merge branch 'develop' into anr-worker-from-base64-script
7ef8050
@timfish
Linting
0c71dcc
@timfish
Merge remote-tracking branch 'origin/anr-worker-from-base64-script' i…
930969b 
…nto anr-worker-from-base64-script
@timfish
Merge remote-tracking branch 'upstream/develop' into anr-worker-from-…
3de4144 
…base64-script
@timfish
Merge remote-tracking branch 'upstream/develop' into anr-worker-from-…
b2d4b66 
…base64-script
@timfish
remove isAnrChildProcess usage
f0ac67e
@timfish
Include parentSpanId in trace context
41cc61d
@timfish
Ensure we get app/device/os/culture context with ANR events
4a7c4fc
@timfish
Fix test
6271c85
@timfish timfish marked this pull request as ready for review December 20, 2023 23:17
@timfish timfish requested a review from lforst December 20, 2023 23:17
@lforst
Copy link
Member

lforst commented Dec 21, 2023

Thank you for redoing this work!

@lforst lforst merged commit 6173846 into getsentry:develop Dec 21, 2023
75 checks passed
@timfish timfish deleted the anr-worker-from-base64-script branch December 21, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lforst lforst lforst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timfish @lforst