Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve interop with objc headers #265

Merged
merged 5 commits into from
Sep 10, 2024
Merged

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Sep 6, 2024

📜 Description

Combine the cinterop libraries that we had into one, remove unnecessary header files thus reducing klib file size

💡 Motivation and Context

Closes #74

💚 How did you test it?

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.

🔮 Next steps

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.43%. Comparing base (5eed211) to head (5f6bce7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #265   +/-   ##
=======================================
  Coverage   75.43%   75.43%           
=======================================
  Files          38       38           
  Lines         574      574           
  Branches       85       85           
=======================================
  Hits          433      433           
  Misses         96       96           
  Partials       45       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I'm wondering how much more we could shave off by implementing this in the Cocoa SDK getsentry/sentry-cocoa#1999. Probably not that much work tbh, but we could do it as a next step improvement later

…lin/multiplatform/nsexception/SentryUnhandledExceptions.kt

Co-authored-by: Roman Zavarnitsyn <rom4ek93@gmail.com>
@buenaflor buenaflor marked this pull request as ready for review September 10, 2024 08:58
@buenaflor buenaflor merged commit e178b2e into main Sep 10, 2024
17 of 19 checks passed
@buenaflor buenaflor deleted the ref/trimmed-headers branch September 10, 2024 09:22
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- improve interop with objc headers ([#265](https://github.com/getsentry/sentry-kotlin-multiplatform/pull/265))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 5f6bce7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use trimmed headers instead of cocoapods for Apple targets
2 participants