Prevent PHP 8.4 deprecation warning (#954)

* prevent PHP 8.4 deprecation for default null value without nullable type declaration * Add php-cs-fixer rule to prevent nullable deprecations --------- Co-authored-by: Alex Bouma <alex@bouma.me>
getsentry · Nov 24, 2024 · 5a3f81b · 5a3f81b
1 parent c26ecb6
commit 5a3f81b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/.php-cs-fixer.php b/.php-cs-fixer.php
@@ -9,6 +9,7 @@
 $config
     ->setRules([
         '@PSR2' => true,
+        'nullable_type_declaration_for_default_null_value' => true,
     ])
     ->setFinder($finder)
 ;

diff --git a/src/Sentry/Laravel/Features/ConsoleSchedulingIntegration.php b/src/Sentry/Laravel/Features/ConsoleSchedulingIntegration.php
@@ -212,7 +212,7 @@ private function sendCheckIn(CheckIn $checkIn): void
         SentrySdk::getCurrentHub()->captureEvent($event);
     }
 
-    private function createCheckIn(string $slug, CheckInStatus $status, string $id = null): CheckIn
+    private function createCheckIn(string $slug, CheckInStatus $status, ?string $id = null): CheckIn
     {
         $options = SentrySdk::getCurrentHub()->getClient()->getOptions();