Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve app paths #86

Closed
dcramer opened this issue Jul 26, 2017 · 3 comments
Closed

Improve app paths #86

dcramer opened this issue Jul 26, 2017 · 3 comments

Comments

@dcramer
Copy link
Member

dcramer commented Jul 26, 2017

I'm not sure how best to approach this, but for example, 'routes' is outside of app_path, and so generating an error there results in a poor user experience. We could use base_path as the app root, but then it includes vendor, which is also a problem. This possibly needs upstream changes to sentry/sentry to make this behavior better.
@dcramer
Copy link
Member Author

dcramer commented Jul 26, 2017

Going to play with something that utilizes excluded_app_paths

@stayallive
Copy link
Collaborator

Maybe it would also be nice to be able to define multiple included/excluded paths.

dcramer added a commit that referenced this issue Jul 26, 2017
@dcramer
Improve default app_path detection
d72c044 
This uses the root of the directory which ensures things like routes and core versioned code are managed, but explicitly excludes vendor.

Refs GH-86
@dcramer dcramer mentioned this issue Jul 26, 2017
Merged
dcramer added a commit that referenced this issue Jul 26, 2017
@dcramer
Improve default app_path detection
b76aea0 
This uses the root of the directory which ensures things like routes and core versioned code are managed, but explicitly excludes vendor.

Refs GH-86
dcramer added a commit that referenced this issue Jul 26, 2017
@dcramer
Improve default app_path detection
f91aea6 
This uses the root of the directory which ensures things like routes and core versioned code are managed, but explicitly excludes vendor.

Refs GH-86
dcramer added a commit that referenced this issue Jul 26, 2017
@dcramer
Improve default app_path detection
efdeeb1 
This uses the root of the directory which ensures things like routes and core versioned code are managed, but explicitly excludes vendor.

Refs GH-86
@dcramer dcramer closed this as completed Jul 26, 2017
@gonzalom gonzalom mentioned this issue Apr 17, 2018
Merged
@gonzalom
Copy link

What about Lumen?

Here you have a pull request for Lumen #128

@jiriko jiriko mentioned this issue Feb 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dcramer @stayallive @gonzalom