Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listen for queue events #153

Merged
merged 2 commits into from
Nov 1, 2018
Merged

Listen for queue events #153

merged 2 commits into from
Nov 1, 2018

Conversation

stayallive
Copy link
Collaborator

Using this in my own apps for some time, seems like a sane approach to do the following when working queue jobs:

  • Send unsent errors as soon as a job is processed since another might take a while to come and the process may not end soon (so make sure all events are sent)
  • Clear the breadcrumbs as soon as a job is processed and events have been sent so there is a clean breadcrumbs record instead of piling on crumbs
  • Add an crumb to indicate which job started and add some metadata about the job

@Jean85 Does this seem like a good approach to take (conceptually)?

# Conflicts:
#	src/Sentry/SentryLaravel/SentryLaravelEventHandler.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant