feat: Use laravel client and options #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 27, 2018
Are you sure about that? Couldn't you have older versions of Laravel under PHP 7.1 and be happy about that? |
HazAT
changed the title
HazAT
force-pushed
the
feat/use-2.0-php-sdk
branch
from
5201ef9 to
b3815af
Compare
stayallive
requested changes
Dec 12, 2018
| 'command' => null, | ||
| )); | ||
| Integration::configureScope(function (Scope $scope) use ($event): void { | ||
| $scope->setTag('command', ''); |
There was a problem hiding this comment.
Better to add a $scope->unsetTag('command') method to the client maybe?
Then we actually remove the tag instead of setting it to an empty string (which probably has the same affect, but still).
There was a problem hiding this comment.
Maybe removeTag would be better, but I agree.
There was a problem hiding this comment.
^ also fine ofcourse 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lumen and Laravel need to be
>= 5.6because of our requirement of PHP>= 7.1It also currently uses a local overwrites in the PHP SDK to make it work.