Switch the order of null coalescing for the sql_bindings config option

src/Sentry/Laravel/EventHandler.php

@@ -65,7 +65,7 @@ class EventHandler
      */
     public function __construct(array $config)
     {
-        $this->recordSqlBindings = ($config['breadcrumbs']['sql_bindings'] ?? $config['breadcrumbs.sql_bindings'] ?? false) === true;
+        $this->recordSqlBindings = ($config['breadcrumbs.sql_bindings'] ?? $config['breadcrumbs']['sql_bindings'] ?? false) === true;
     }
 
     /**

test/Sentry/SqlBindingsInBreadcrumbsWithOldConfigKeyDisabledTest.php

@@ -0,0 +1,51 @@
+<?php
+
+namespace Sentry\Laravel\Tests;
+
+use Sentry\State\Hub;
+use Illuminate\Config\Repository;
+
+class SqlBindingsInBreadcrumbsWithOldConfigKeyDisabledTest extends SentryLaravelTestCase
+{
+    protected function getEnvironmentSetUp($app)
+    {
+        parent::getEnvironmentSetUp($app);
+
+        $app['config']->set('sentry.dsn', 'http://publickey:secretkey@sentry.dev/123');
+
+        $config = $app['config']->all();
+
+        $config['sentry']['breadcrumbs.sql_bindings'] = false;
+
+        $app['config'] = new Repository($config);
+    }
+
+    public function testIsBound()
+    {
+        $this->assertTrue(app()->bound('sentry'));
+        $this->assertInstanceOf(Hub::class, app('sentry'));
+    }
+
+    /**
+     * @depends testIsBound
+     */
+    public function testSqlBindingsAreRecordedWhenDisabledByOldConfigKey()
+    {
+        $this->assertFalse($this->app['config']->get('sentry')['breadcrumbs.sql_bindings']);
+
+        $this->dispatchLaravelEvent('illuminate.query', [
+            $query = 'SELECT * FROM breadcrumbs WHERE bindings = ?;',
+            $bindings = ['1'],
+            10,
+            'test',
+        ]);
+
+        $breadcrumbs = $this->getScope(Hub::getCurrent())->getBreadcrumbs();
+
+        /** @var \Sentry\Breadcrumb $lastBreadcrumb */
+        $lastBreadcrumb = end($breadcrumbs);
+
+        $this->assertEquals($query, $lastBreadcrumb->getMessage());
+        $this->assertFalse(isset($lastBreadcrumb->getMetadata()['bindings']));
+    }
+}

test/Sentry/SqlBindingsInBreadcrumbsWithOldConfigKeyTest.php → test/Sentry/SqlBindingsInBreadcrumbsWithOldConfigKeyEnabledTest.php

@@ -5,7 +5,7 @@
 use Sentry\State\Hub;
 use Illuminate\Config\Repository;
 
-class SqlBindingsInBreadcrumbsWithOldConfigKeyTest extends SentryLaravelTestCase
+class SqlBindingsInBreadcrumbsWithOldConfigKeyEnabledTest extends SentryLaravelTestCase
 {
     protected function getEnvironmentSetUp($app)
     {
@@ -17,8 +17,6 @@ protected function getEnvironmentSetUp($app)
 
         $config['sentry']['breadcrumbs.sql_bindings'] = true;
 
-        unset($config['sentry']['breadcrumbs']);
-
         $app['config'] = new Repository($config);
     }