Refactor HTTP client integration feature #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
stayallive
changed the title
GuzzleTracingMiddleware as global middleware on Laravel HTTP client by default
stayallive
force-pushed
the
http-global-middleware
branch
from
256ee11
to
9a9e8fc
Compare
cleptric
reviewed
Nov 14, 2023
cleptric
approved these changes
Nov 15, 2023
cleptric
force-pushed
the
http-global-middleware
branch
from
49a3612
to
154e32f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the HTTP client integration to make use of the Feature structure and cleanup the code overal and increase test coverage. Some other goals:
baggageandsentry-traceheaders to requests (using [10.x] Add global middleware toHttpclient laravel/framework#47525)