-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: thread context from breakpad on macos #1083
Conversation
…on macOS from the breakpad backend.
|
…reakpad backend.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1083 +/- ##
==========================================
+ Coverage 82.36% 82.38% +0.02%
==========================================
Files 53 53
Lines 7752 7751 -1
Branches 1216 1216
==========================================
+ Hits 6385 6386 +1
+ Misses 1255 1253 -2
Partials 112 112
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Upstream
breakpad
doesn't provide the thread context to the handler callbacks (it does write it to the minidump, though). This change fills the context of the crashed thread and passes it on to the handler callback (which in turn passes it on to theon_crash
andbefore_send
callbacks).The change keeps compatibility between upstream and our fork in both directions even though this breaks one of the public interfaces:
breakpad
backend in the Native SDK uses the upstream interface ifSENTRY_BREAKPAD_SYSTEM
is definedbreakpad
fork provides the modified interface only if compiled with the Native SDK (i.e.,SENTRY_BACKEND_BREAKPAD
is defined in thebreakpad_client
target).