Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: thread context from breakpad on macos #1083

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

supervacuus
Copy link
Collaborator

Upstream breakpad doesn't provide the thread context to the handler callbacks (it does write it to the minidump, though). This change fills the context of the crashed thread and passes it on to the handler callback (which in turn passes it on to the on_crash and before_send callbacks).

The change keeps compatibility between upstream and our fork in both directions even though this breaks one of the public interfaces:

  • our breakpad backend in the Native SDK uses the upstream interface if SENTRY_BREAKPAD_SYSTEM is defined
  • our breakpad fork provides the modified interface only if compiled with the Native SDK (i.e., SENTRY_BACKEND_BREAKPAD is defined in the breakpad_client target).

Copy link

github-actions bot commented Nov 19, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 4320b6b

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.38%. Comparing base (2ad5f0d) to head (4320b6b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1083      +/-   ##
==========================================
+ Coverage   82.36%   82.38%   +0.02%     
==========================================
  Files          53       53              
  Lines        7752     7751       -1     
  Branches     1216     1216              
==========================================
+ Hits         6385     6386       +1     
+ Misses       1255     1253       -2     
  Partials      112      112              
---- 🚨 Try these New Features:

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

src/backends/sentry_backend_breakpad.cpp Show resolved Hide resolved
Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@supervacuus supervacuus merged commit 43e00a9 into master Nov 20, 2024
24 checks passed
@supervacuus supervacuus deleted the feat/thread_context_breakpad_macos branch November 20, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants