Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using libunwind for mac, since backtrace do not expect thread context… #1088

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

saf-e
Copy link

@saf-e saf-e commented Nov 21, 2024

… (i.e. working just with current thread)

#skip-changelog

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 55.00000% with 27 lines in your changes missing coverage. Please review.

Project coverage is 82.14%. Comparing base (d431ab9) to head (03eec55).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1088      +/-   ##
==========================================
- Coverage   82.38%   82.14%   -0.25%     
==========================================
  Files          53       53              
  Lines        7751     7811      +60     
  Branches     1216     1238      +22     
==========================================
+ Hits         6386     6416      +30     
- Misses       1253     1263      +10     
- Partials      112      132      +20     
---- 🚨 Try these New Features:

@saf-e saf-e force-pushed the pr/geting_context_for_mac branch from 5a591e0 to c5f6535 Compare November 21, 2024 14:35
@kahest kahest requested a review from supervacuus November 28, 2024 15:45
@supervacuus
Copy link
Collaborator

Thanks for the PR; introducing libunwind for macOS has been on our wish list for some time. This requires a bit more work on our side before we can merge it since ucontext-based stack tracing also affects the signal handler in the inproc backend. Further, the unwinder, as currently implemented, will have issues if system functions end up as leaves in the ucontext after being delivered from the signal trampoline.

If you are okay with it, I will take this over, adapt the current unwinder code for usage in inproc (and other signal handler users), and extract it into a separate unwinder module. But not before next week.

@supervacuus supervacuus self-assigned this Dec 5, 2024
@saf-e
Copy link
Author

saf-e commented Dec 5, 2024

If you are okay with it, I will take this over, adapt the current unwinder code for usage in inproc (and other signal handler users), and extract it into a separate unwinder module. But not before next week.

Yes, no problem with that, fill free to adapt it to your needs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants