expand on what is sentry_capture_minidump for #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- expand on what is sentry_capture_minidump for ([#1157](https://github.com/getsentry/sentry-native/pull/1157))If none of the above apply, you can opt out of this check by adding |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1157 +/- ##
==========================================
- Coverage 82.66% 82.61% -0.06%
==========================================
Files 53 53
Lines 7954 7954
Branches 1246 1246
==========================================
- Hits 6575 6571 -4
- Misses 1266 1267 +1
- Partials 113 116 +3 |
supervacuus
approved these changes
Feb 25, 2025
Comment on lines
+1408
to
+1411
| * | ||
| * You don't need this function if you're relying on Sentry to create the minidump. | ||
| * This is useful when you have a minidump captured through a different mechanism, | ||
| * and you want Sentry to ingest it. |
There was a problem hiding this comment.
This is great, but I would add it as a Note: paragraph at the end of the inline comment. We do this with most meta descriptions in the header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been causing confusion.
More API doc hopefully to help clarify things.