-
-
Notifications
You must be signed in to change notification settings - Fork 200
ci: use Alpine Linux Docker image #1261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can't you just manually dispatch the docker workflow from the PR branch and then rerun the CI workflow? |
For security reasons, the workflow must exist in the default branch to be able to trigger |
|
Thanks, seems like it worked so we don't need multiple steps... 🎉 https://github.com/getsentry/sentry-native/pkgs/container/sentry-native-alpine |
supervacuus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but I would like to have an idea of the updates to the image. Your primary concern will be updates to the Alpine base, but even minor changes (such as filtering on branches) could make this significantly safer.
Reverts most of the Alpine-specific steps introduced in #1233 by using a prebuilt Alpine Linux Docker image with relevant tools and dependencies pre-installed:
Close: #1240
#skip-changelog