Skip to content

Conversation

@jpnurmi
Copy link
Collaborator

@jpnurmi jpnurmi commented Jun 2, 2025

Reverts most of the Alpine-specific steps introduced in #1233 by using a prebuilt Alpine Linux Docker image with relevant tools and dependencies pre-installed:

Close: #1240

#skip-changelog

@supervacuus
Copy link
Collaborator

Note: Once everything looks good, the first commit needs to be cherry-picked into a separate PR, merged first, and run once to make the Docker image available at getsentry/packages. Until then, the image is temporarily published from a personal fork.

Can't you just manually dispatch the docker workflow from the PR branch and then rerun the CI workflow?

@jpnurmi
Copy link
Collaborator Author

jpnurmi commented Jun 2, 2025

Can't you just manually dispatch the docker workflow from the PR branch and then rerun the CI workflow?

For security reasons, the workflow must exist in the default branch to be able to trigger workflow_dispatch but it made me wonder if workflow_call from the PR branch is allowed...

@jpnurmi jpnurmi changed the title wip: use Alpine Linux Docker image ci: use Alpine Linux Docker image Jun 2, 2025
@jpnurmi
Copy link
Collaborator Author

jpnurmi commented Jun 2, 2025

Thanks, seems like it worked so we don't need multiple steps... 🎉

https://github.com/getsentry/sentry-native/pkgs/container/sentry-native-alpine

@jpnurmi jpnurmi marked this pull request as ready for review June 2, 2025 16:08
Copy link
Collaborator

@supervacuus supervacuus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but I would like to have an idea of the updates to the image. Your primary concern will be updates to the Alpine base, but even minor changes (such as filtering on branches) could make this significantly safer.

@jpnurmi jpnurmi merged commit 1fe9121 into master Jun 3, 2025
35 checks passed
@jpnurmi jpnurmi deleted the ci/alpine branch June 3, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Alpine Linux Docker image

3 participants