ref: crashpad: pre-generate crash event ID#1319
Merged
Conversation
jpnurmi
added a commit
that referenced
this pull request
Jul 20, 2025
vaind
approved these changes
Jul 21, 2025
Contributor
vaind
left a comment
There was a problem hiding this comment.
LGTM except for the name of the new function
Co-authored-by: Ivan Dlugos <6349682+vaind@users.noreply.github.com>
vaind
approved these changes
Jul 21, 2025
jpnurmi
added a commit
that referenced
this pull request
Jul 21, 2025
JoshuaMoelans
approved these changes
Jul 25, 2025
Member
JoshuaMoelans
left a comment
There was a problem hiding this comment.
LGTM, minor nit on adding a more clarifying docstring
Co-authored-by: JoshuaMoelans <60878493+JoshuaMoelans@users.noreply.github.com>
1 task
This was referenced Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-generate an event ID for a potential future crash on the client side to be able to associate feedback with the crash event at the time of the crash. Extracted from #1303.
Before, Crashpad events (
__sentry-event) were sent without ID. Even if the server generated an ID on demand and sent it as a response, it was too late for the upcoming feedback handler / crash reporter (#1223). It needs an ID before the event is sent because the user might not give consent to send anything at all.Before
msgpack2json -p -i <run>/__sentry-event{ "level": "fatal", "platform": "native", "release": "sentry-playground@1.2.3", "environment": "development", "sdk": { "name": "sentry.native", "version": "0.9.1", "packages": [ { "name": "github:getsentry/sentry-native", "version": "0.9.1" } ], "integrations": [ "crashpad" ] }, "tags": { "backend": "crashpad" }, "extra": {}, "contexts": { "os": { "name": "macOS", "version": "15.5.0", "build": "24F74", "kernel_version": "24.5.0" }, "trace": { "trace_id": "be7045b229de43014da2b15ceb4dbedf", "span_id": "4a800c2ce1b24ebf", "sample_rand": 0.3444084273172463 } } }After
msgpack2json -p -i <run>/__sentry-event{ "event_id": "62e3e0f8-d0d1-450a-1f6e-89faf1fe3862", "level": "fatal", "platform": "native", "release": "sentry-playground@1.2.3", "environment": "development", "sdk": { "name": "sentry.native", "version": "0.9.1", "packages": [ { "name": "github:getsentry/sentry-native", "version": "0.9.1" } ], "integrations": [ "crashpad" ] }, "tags": { "backend": "crashpad" }, "extra": {}, "contexts": { "os": { "name": "macOS", "version": "15.5.0", "build": "24F74", "kernel_version": "24.5.0" }, "trace": { "trace_id": "10b740a911374e5d4d918308abed7cd2", "span_id": "2f040e2ccb5b4460", "sample_rand": 0.502786153155452 } } }