feat(logs): add sentry__logs_force_flush on calling sentry_flush#1434
Merged
JoshuaMoelans merged 7 commits intomasterfrom Nov 17, 2025
Merged
feat(logs): add sentry__logs_force_flush on calling sentry_flush#1434JoshuaMoelans merged 7 commits intomasterfrom
sentry__logs_force_flush on calling sentry_flush#1434JoshuaMoelans merged 7 commits intomasterfrom
Conversation
|
mujacica
approved these changes
Nov 13, 2025
# Conflicts: # CHANGELOG.md # tests/unit/test_logs.c
# Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1425
Adds a forced flush call in
sentry_flush.Details
We wait on in-progress flushes by doing
Since otherwise, we could be actively flushing from the batching thread & logs might have already been written to the secondary buffer, which we would then not be flushing with the
force_flushsinceflushingwas true (-> early exit from theflush_queuefunction)