Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Run analyzers and leak-check on CI #299

Merged
merged 2 commits into from
Jun 17, 2020
Merged

ci: Run analyzers and leak-check on CI #299

merged 2 commits into from
Jun 17, 2020

Conversation

Swatinem
Copy link
Member

@Swatinem Swatinem commented Jun 16, 2020

  • run scan-build (clang analyzer) on linux (although currently it only produces warnings and not hard errors)
  • switch to gcc-10 and clang-10 on linux
  • run asan leak-check on clang builds on linux

@Swatinem Swatinem force-pushed the ci/leaks branch 2 times, most recently from 4379bc5 to dbfd46a Compare June 16, 2020 15:59
@Swatinem Swatinem changed the title ci: Run leak sanitizer on CI ci: Run analyzers and leak-check on CI Jun 16, 2020
* run `scan-build` (clang analyzer) on linux (currently only produces warnings)
* switch to gcc-10 and clang-10 on linux
* run asan leak-check on clang builds on linux
@Swatinem Swatinem requested a review from a team June 17, 2020 08:53
@Swatinem Swatinem marked this pull request as ready for review June 17, 2020 08:53
CC: gcc-10
CXX: g++-10
# GCC does not respect the `-Wvariadic-macros` suppression right now
# ERROR_ON_WARNINGS: 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would you feel if we stay on GCC 9 until this is resolved?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remember correctly, it had the same problems, lol.

src/sentry_logger.c Outdated Show resolved Hide resolved
@Swatinem Swatinem merged commit 776ccc3 into master Jun 17, 2020
@Swatinem Swatinem deleted the ci/leaks branch June 17, 2020 09:29
irov pushed a commit to irov/sentry-native that referenced this pull request Jun 17, 2020
* run `scan-build` (clang analyzer) on linux (currently only produces warnings)
* switch to gcc-10 and clang-10 on linux
* run asan leak-check on clang builds on linux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants